feat: optimize collecting entity when match empty column in entityCollecting context#467
Open
Cythia828 wants to merge 1 commit intofeat/emptyColumnfrom
Open
feat: optimize collecting entity when match empty column in entityCollecting context#467Cythia828 wants to merge 1 commit intofeat/emptyColumnfrom
Cythia828 wants to merge 1 commit intofeat/emptyColumnfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解决问题
在 #457 的基础上继续解决
目前剩余问题
PGSQL在某些语法不完整的情况下不会抛错，原因是pgsql的语法文件比较特殊，我们的方案是用语义谓词去做判断，但是当语义谓词为false的情况下，当前语义谓词所在的分支会跳过去执行下一个分支，而刚好我们当前所在的父级规则所在的分支里是可选的，所以会导致这里不完整也是能通过语法检测的
Preview地址
https://cythia828.github.io/monaco-sql-languages/